Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add konflux favicon #69

Merged
merged 4 commits into from
Jan 16, 2025
Merged

fix: add konflux favicon #69

merged 4 commits into from
Jan 16, 2025

Conversation

sahil143
Copy link
Collaborator

@sahil143 sahil143 commented Jan 10, 2025

fixes: #34,
fixes: #33

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (4785508) to head (a727f9d).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         569      569           
  Lines       21379    21379           
  Branches     5286     5294    +8     
=======================================
  Hits        17107    17107           
  Misses       4247     4247           
  Partials       25       25           
Flag Coverage Δ
unittests 80.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoaoPedroPP
Copy link
Contributor

LGTM

@JoaoPedroPP
Copy link
Contributor

Multiples MR are having the same issue in the Red Hat Konflux check

@sahil143 sahil143 closed this Jan 13, 2025
@sahil143 sahil143 reopened this Jan 13, 2025
@testcara
Copy link
Contributor

LGTM

@sahil143 sahil143 merged commit f381e70 into konflux-ci:main Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

favicon should show the konflux logo Readme should mention which node version should be used for development
4 participants